Skip to content

Conversation

@thechenky
Copy link
Contributor

@thechenky thechenky commented Jun 20, 2019

Description

Remote Config integration tests were previously commented out because of an issue running them in preprod environment (bug reference 124524632). I was able to run with these tests uncommented out in both prod and preprod environments with all tests passing.

Code sample

Ensure the project you're using to run the tests has billing enabled and Firestore API enabled with Firestore created.

# to run in prod:
./integration_test/run_tests.sh <project_id>

# to run in preprod, first set this env var:
export FIREBASE_FUNCTIONS_URL="https://preprod-cloudfunctions.sandbox.googleapis.com"
./integration_test/run_tests.sh <project_id>

# unset the env var:
unset FIREBASE_FUNCTIONS_URL

@thechenky thechenky requested a review from kevinajian June 20, 2019 17:21
@thechenky
Copy link
Contributor Author

Verifying one last time that all tests are passing - unit, integration in prod, and integration in preprod, then will merge this in.

@thechenky thechenky merged commit d53c7b0 into master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants